Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Madina/feature/380 new colours and dropdown for navbar #387

Open
wants to merge 53 commits into
base: dev
Choose a base branch
from

Conversation

madinamacow
Copy link

@madinamacow madinamacow commented Feb 9, 2025

📄 Pull Request Overview

closes #380

🔧 Changes Made

  1. Description
    This pull request introduces the new navbar design and improves UI consistency.
    The changes include:
  • Copied the current navbar to NavbarMobileV2 and NavbarDesktopV2 folders.
  • Applied new colors from the global SCSS system.
  • Removed the Teachers link from the navbar.
  • Implemented the dropdown system.
  • Ensured responsiveness and UI consistency.
  • Update tests to validate functionality.

Testing*

  • Verified that the new colors are applied correctly.
  • Checked that the Teachers link is removed.
  • Ensured that the dropdown system works as expected.
  • Tested responsiveness on different screen sizes.

  • Screenshots: [Include any screenshots or videos if the changes affect the UI]

  • Desktop

image

I think this looks better in my opinion tell me you think?
image

  • Mobile
    image

@madinamacow madinamacow self-assigned this Feb 9, 2025
@madinamacow madinamacow added enhancement For improvements to existing features feature For new features labels Feb 9, 2025
Copy link
Collaborator

@Jonroi Jonroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1. Drop Shadows

  • The drop shadows seen below and on the right are critical for the design. These shadows need to be added to maintain the original aesthetic.

2. Hover/Clicked Effect (Desktop Navbar)

  • The Hover effect and clicked effect for the desktop navbar currently in place needs to be updated. Please replace the existing one with the effect shown in Figma for consistency.

3. Dropdown Behavior

  • Please contact @Terhi-S for intended behavior of the dropdowns. Should they:
    • Open all at once when the navbar is hovered over?
    • Or should they open one by one when hovered over each item?
  • This needs to be finalized for the correct implementation.

Hover Effect

Hover Effect


Dropdowns & Drop Shadows

Dropdowns


I'll continue reviewing once these are addressed. Overall, the work is great and includes the tuned storybook and tests, but a bit of tweaking is needed to complete it.

@Skoivumaki
Copy link
Member

Please contact @Terhi-S for intended behavior of the dropdowns. Should they:
Open all at once when the navbar is hovered over?
Or should they open one by one when hovered over each item?

I believe developer should have an option to choose which to use, entire row or single column. Why: On smaller desktop devices the font size may become too big to handle and elements may collide/overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For improvements to existing features feature For new features
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants