-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Madina/feature/380 new colours and dropdown for navbar #387
base: dev
Are you sure you want to change the base?
Madina/feature/380 new colours and dropdown for navbar #387
Conversation
…layout adjustments.
…dropdown functionality.
…ropdown behavior.
…ts, and dropdown behavior.
…color adjustments.
…and setOpenDropdown props.
…move unused blur handler.
…better state management.
…e state indication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Drop Shadows
- The drop shadows seen below and on the right are critical for the design. These shadows need to be added to maintain the original aesthetic.
2. Hover/Clicked Effect (Desktop Navbar)
- The Hover effect and clicked effect for the desktop navbar currently in place needs to be updated. Please replace the existing one with the effect shown in Figma for consistency.
3. Dropdown Behavior
- Please contact @Terhi-S for intended behavior of the dropdowns. Should they:
- Open all at once when the navbar is hovered over?
- Or should they open one by one when hovered over each item?
- This needs to be finalized for the correct implementation.
Hover Effect
Dropdowns & Drop Shadows
I'll continue reviewing once these are addressed. Overall, the work is great and includes the tuned storybook and tests, but a bit of tweaking is needed to complete it.
I believe developer should have an option to choose which to use, entire row or single column. Why: On smaller desktop devices the font size may become too big to handle and elements may collide/overflow. |
…ting DropdownWrapper props.
📄 Pull Request Overview
closes #380
🔧 Changes Made
This pull request introduces the new navbar design and improves UI consistency.
The changes include:
✅ Testing*
Screenshots: [Include any screenshots or videos if the changes affect the UI]
Desktop
I think this looks better in my opinion tell me you think?
![image](https://private-user-images.githubusercontent.com/144919853/411353594-8cf51a44-382f-4aff-88ac-2c6b643e5f35.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0Mzk3NzIsIm5iZiI6MTczOTQzOTQ3MiwicGF0aCI6Ii8xNDQ5MTk4NTMvNDExMzUzNTk0LThjZjUxYTQ0LTM4MmYtNGFmZi04OGFjLTJjNmI2NDNlNWYzNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwOTM3NTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hODY3NzQ4MDMwMDNhNGZmOTlkZjU5NGUzYTBhZjQ5OGNjMGMyYmRiOTM2NzZjNTU5ZTU4NTdkNzI0N2YyNjcwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.XGeGfTOWPDTW9yr5LJQ0Y8mlu4vch5Id5ObY0-hxbts)