Joni/bug/19-autoscroll-bug-on-every-page #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented out the import and export for createMetadataGenerator in profile page. Added a TODO note to enable it once it is added to i18n locales.
Commented out the import and export for createMetadataGenerator in profile page. Added a TODO note to enable it once it is added to i18n locales.
Created _getPage.ts for the team page to support localization using `useServerTranslation` for dynamic SEO content. This enhances the team's page with translated titles, descriptions, and keywords based on the language parameter.
Modified the export statement to use named export for better consistency and readability. This change ensures the MembersPage component is explicitly named when imported elsewhere in the project.
Refactored the `team/page.ts` to incorporate the `withPageData` HOC for better code reuse and maintainability. Simplified metadata generation by replacing the manual function with `createMetadataGenerator`.
A TODO comment has been added to highlight the need for i18n implementation if possible. This serves as a reminder to handle internationalization in the future.
Consolidate utility imports under a single `_helpers` directory for better organization and maintainability. This change reduces redundancy and centralizes shared functionality across the app.
This commit removes an unnecessary newline in the page.tsx file. This change helps maintain cleaner code and adheres to code formatting standards.
Leo/refactor/app router
This change adds 'robots' to the list of excluded paths in the route matcher configuration. It ensures that requests to the 'robots' path are not intercepted by the middleware, which helps in correctly serving the robots.txt file for web crawlers.
Created a robots.txt file in the public directory to specify site indexing rules for all user agents. Included a link to the sitemap to improve site crawling efficiency.
This commit introduces a horizontal padding adjustment to the main container in the SCSS file. This change ensures consistent spacing by calculating the padding dynamically based on the viewport width.
Commented out max-width style in .SectionPlayWithUs. Adjusted font size to 2rem for screens under 1500px width. Slightly decreased font size to 2.4rem for screens under 450px width.
Commented out redundant padding in the main container to avoid duplicate declarations and ensure more maintainable code. This change helps to avoid jumps when scrollbars appear.
Changed the title translation key from "title" to "Comics" to ensure the correct translation is retrieved. This adjusts the displayed page title to be more accurate and contextually appropriate.
Feature/82 add robotstxt
Introduced a new background image to enhance page aesthetics. Updated the layout.tsx file to apply the new background style using a webp image.
Applied white color for the scrollbar thumb and black for the track. Set the scrollbar width to thin to enhance the UI appearance.
Enhanced the custom scrollbar mixin to include specific styles for Firefox browsers using the @-moz-document rule. This ensures a consistent look across different browsers by setting the scrollbar color and width appropriately in Firefox.
Moved custom scrollbar styles into a `@-moz-document` block for Firefox-specific adjustments. This refactor ensures scrollbars are styled consistently across browsers and improves maintainability by consolidating related styles.
This change updates the import paths for withPageData and createMetadataGenerator to use absolute paths consistently. It improves maintainability and readability of the code by ensuring all helper imports follow the same path convention.
Added a `bin` property to `package.json` for command line usage and introduced the `ts-morph` package for programmatic manipulation of TypeScript code. Also included new dependencies for the project.
This commit adds the 'Project' import from 'ts-morph' to the sortImports.ts file. This is necessary to use 'Project' within the file and prevent potential runtime errors.
… desktop logic, add JSDoc documentation
Changed the useTranslation function to automatically determine the language from URL parameters using useParams from Next.js. This removes the need to explicitly pass the language as an argument, simplifying the function call and ensuring consistent language detection throughout the application.
Removed unnecessary useParams imports and updated translation function calls to enhance code simplicity and maintainability across multiple files. This change reduces redundancy and potential errors linked to language parameters.
…ation-can-include-getting-language-from-nextjs Leo/refactor/122 useclienttranslation can include getting language from nextjs
…-on-comingsoon-component Leo/bug/117 fix responsive issue on comingsoon component
Replaced commented min-height of 100vh with an active 100dvh value. This change ensures correct dynamic viewport height scaling across devices.
Added flexbox centering to NewsPage for better alignment. Refined ComingSoon component by removing redundant CSS classes, updating padding, and using a variable for border-radius.
The FeedbackSideButton component was removed from the news layout to improve page aesthetics and reduce distractions for users. This change aims to streamline the layout and enhance user experience by focusing on primary content elements.
Added flexbox alignment styles to centrally position the "Coming Soon" widget. Also, removed an outdated TODO comment from the NewsPage component.
Temporarily disable the CSS rules for the `.NewsPage` component by
Commented out the gallery section code in `VideoAndGalleries.tsx` while leaving the rest of the component untouched. This change might be temporary but will help focus on the video content exclusively for now.
Reorganized MainPage components to ensure proper section order. Commented out the "GetToKnowComics" component and some HorizontalLines to clean up the layout and focus on essential parts of the page.
Added a TODO comment suggesting a split into two different components: one with galleries and one without. This is to address varying requirements and enhance maintainability of the codebase.
Adjusted the margin properties to use clamp for more adaptive spacing. Commented out redundant margin-top assignment in responsive settings and removed unnecessary HorizontalLines margin.
Inserted placeholder comments to mark sections for adding Instagram content and considering separate components for with and without galleries. These comments act as reminders for future enhancements and component separation.
Updated the translations for "comics" from "Sarjakuvat" to "Sarjakuva" in fi/navbar.json and fi/comics.json. This change ensures consistency across the application.
Updated the term from "Comics" to "Comic Book" in the navbar JSON file and "Our Comic Book" in the comics.json file for consistency. This change helps provide clearer navigation labels and aligns with the content structure.
Temporarily reverted async loading of Comics and Picture Gallery pages due to loading issues. Added TODO comments for future improvements to avoid sudden jumps during loading.
…tion-from-main-page
…d-our-art-section-from-main-page Joni/hotfix/remove-comic-link-and-our-art-section-from-main-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #19