tests: fixing broken quality_control example + tests

AllenNeuralDynamics · Aug 27, 2024 · f432f84 · f432f84
1 parent 443a660
commit f432f84
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 12 deletions.
diff --git a/examples/quality_control.json b/examples/quality_control.json
@@ -1,5 +1,5 @@
 {
-   "describedBy": "https://raw.githubusercontent.com/AllenNeuralDynamics/aind-data-schema/main/src/aind_data_schema/core/quality_metrics.py",
+   "describedBy": "https://raw.githubusercontent.com/AllenNeuralDynamics/aind-data-schema/main/src/aind_data_schema/core/quality_control.py",
    "schema_version": "1.0.0",
    "overall_status": "Pass",
    "overall_status_date": "2022-11-22",
@@ -12,11 +12,18 @@
          "evaluation_stage": "Data acquisition",
          "evaluator_full_name": "Fred Flinstone",
          "evaluation_date": "2022-11-22",
-         "qc_metrics": {
-            "Video_1_num_frames": 662,
-            "Video_2_num_frames": 662,
-            "Frame_match": true
-         },
+         "qc_metrics": [
+            {
+               "name": "Video_frame_match",
+               "value": {
+                  "Video_1_num_frames": 662,
+                  "Video_2_num_frames": 662,
+                  "Frame_match": true
+               },
+               "description": null,
+               "references": null
+            }
+         ],
          "stage_status": "Pass",
          "notes": null
       },
@@ -28,11 +35,26 @@
          "evaluation_stage": "Data acquisition",
          "evaluator_full_name": "Fred Flinstone",
          "evaluation_date": "2022-11-22",
-         "qc_metrics": {
-            "ProbeA_success": true,
-            "ProbeB_success": true,
-            "ProbeC_success": false
-         },
+         "qc_metrics": [
+            {
+               "name": "ProbeA_success",
+               "value": true,
+               "description": null,
+               "references": null
+            },
+            {
+               "name": "ProbeB_success",
+               "value": true,
+               "description": null,
+               "references": null
+            },
+            {
+               "name": "ProbeC_success",
+               "value": true,
+               "description": null,
+               "references": null
+            }
+         ],
          "stage_status": "Pass",
          "notes": null
       }

diff --git a/tests/test_quality_control.py b/tests/test_quality_control.py
@@ -29,13 +29,14 @@ def test_constructors(self):
                     evaluation_stage="Spike sorting",
                     qc_metrics=[
                         QCMetric(
+                            name="Multiple values example",
                             value={"stuff": "in_a_dict"}
                         ),
                         QCMetric(
                             name="Drift map pass/fail",
                             value=False,
                             description="Manual evaluation of whether the drift map looks good",
-                            references="s3://some-data-somewhere"
+                            references=["s3://some-data-somewhere"]
                         )
                     ],
                     stage_status="Pass",