Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPL Analysis: introduce PersistentColumn concept #12648

Closed
wants to merge 1 commit into from
Closed

DPL Analysis: introduce PersistentColumn concept #12648

wants to merge 1 commit into from

Conversation

ktf
Copy link
Member

@ktf ktf commented Feb 2, 2024 •
edited
Loading

DPL Analysis: introduce PersistentColumn concept

This way the compiler does not need to instanciate the conjuction type
and it will point to exactly which column is not persistent, when needed.

@ktf ktf requested a review from a team as a code owner February 2, 2024 11:54
@ktf ktf changed the title DPL Analysis: introduce PersistenColumn concept DPL Analysis: introduce PersistentColumn concept Feb 2, 2024
@ktf ktf force-pushed the pr12648 branch 2 times, most recently from 2489a28 to 29e513b Compare February 2, 2024 12:07
@alibuild
Copy link
Collaborator

alibuild commented Feb 2, 2024

Error while checking build/O2/fullCI for 29e513b at 2024-02-02 15:19:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/12648-slc8_x86-64/0/Detectors/AOD/include/AODProducerWorkflow/AODProducerWorkflowSpec.h:246:15: error: field declaration 'cSpeed' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:29:7: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:29:7: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:52:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:53:5: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:73:38: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:74:38: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:83:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:84:5: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:101:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:101:14: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:108:37: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:108:45: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:109:49: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:109:63: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:118:11: error: field declaration 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:119:11: error: field declaration 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/Detectors/AOD/include/AODProducerWorkflow/AODProducerWorkflowSpec.h:246:15: error: field declaration 'cSpeed' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/Detectors/AOD/src/AODProducerWorkflowSpec.cxx:2392:72: error: field reference 'cSpeed' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/Detectors/AOD/src/AODProducerWorkflowSpec.cxx:2401:59: error: field reference 'cSpeed' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/Detectors/AOD/src/AODProducerWorkflowSpec.cxx:2754:74: error: field reference 'cSpeed' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/Detectors/AOD/src/AODProducerWorkflowSpec.cxx:2764:39: error: field reference 'cSpeed' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:146:57: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:206:62: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:277:9: error: field declaration 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:322:50: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:346:19: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:347:19: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:146:57: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:206:62: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:277:9: error: field declaration 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:322:50: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:346:19: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:347:19: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:146:57: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:206:62: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:277:9: error: field declaration 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12648-slc8_x86-64/0/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h:322:50: error: field reference 'fInterpolationSafetyMargin' does not match naming rule [aliceO2-member-name]
[0 more errors; see full log]

Full log here.

@ktf
DPL Analysis: introduce PersistentColumn concept
ec23d75 
This way the compiler does not need to instanciate the conjuction type
and it will point to exactly which column is not persistent, when needed.
@aalkin
Copy link
Member

aalkin commented Feb 5, 2024

Concept is certainly better than a conjunction, however this protection is redundant - these functions are only used internally by Table and only with persistent columns pack. If somehow they would be called with a non-persistent pack, the code would simply fail at runtime.

@alibuild
Copy link
Collaborator

alibuild commented Feb 5, 2024 •
edited
Loading

Error while checking build/O2/fullCI for ec23d75 at 2024-02-13 02:32:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
task timeout reached .. killing all processes


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/fa91774b9696f39fd1899ac986ff2828ee0f0b01/slc8_x86-64/o2checkcode/1.0-local62/etc/modulefiles
++ cat
--

Full log here.

@ktf
Copy link
Member Author

ktf commented Feb 22, 2024

Fair enough, closing.

@ktf ktf closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktf @alibuild @aalkin