Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to disable SSL certificate verification #223

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jeqo
Copy link
Contributor

@jeqo jeqo commented Jan 5, 2024

No description provided.

@jeqo jeqo force-pushed the jeqo/http-ssl-hostname-check-disable branch from 316479f to 6f6011b Compare January 5, 2024 20:44
@jeqo jeqo changed the title feat: add flag to disable hostname verification feat: add flag to disable SSL certificate verification Jan 8, 2024
@jeqo jeqo force-pushed the jeqo/http-ssl-hostname-check-disable branch from 6f6011b to e40b353 Compare January 8, 2024 09:58
@jeqo jeqo mentioned this pull request Jan 8, 2024
@chatchaisi
Copy link

@jeqo I build this branch for test disable self-sign certificate. My team test this function is work.

Test case

  1. Configuration http.ssl.trust.all.certs is false
    1.1 Request with http (PASS)
    1.2 Request with https self-sign certificate is throw error (PASS)
  2. Configuration http.ssl.trust.all.certs is true
    2.1 Request with http (PASS)
    2.2 Request with https self-sign certificate is not throw error (PASS)

Thank you for support. Please merge this branch to main.

@jeqo jeqo marked this pull request as ready for review March 5, 2024 09:51
@jeqo jeqo requested review from a team as code owners March 5, 2024 09:51
@jeqo jeqo force-pushed the jeqo/http-ssl-hostname-check-disable branch from e40b353 to a7044fe Compare March 6, 2024 09:11
@jeqo jeqo force-pushed the jeqo/http-ssl-hostname-check-disable branch from a7044fe to f9b8b9a Compare March 6, 2024 09:14
@jeqo jeqo requested a review from AnatolyPopov March 6, 2024 09:14
Copy link
Contributor

@AnatolyPopov AnatolyPopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnatolyPopov AnatolyPopov merged commit 37108c9 into main Mar 6, 2024
8 checks passed
@AnatolyPopov AnatolyPopov deleted the jeqo/http-ssl-hostname-check-disable branch March 6, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants