Configure s3 api to use AWS Prefix #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aindriu-aiven
commented
Dec 11, 2024
•
aindriu-aiven
commented
- This update means we can now use the PREFIX in the AWS API allowing users to configure it to be more specific about what they want processed by the connector.
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
aindriu-aiven
force-pushed
the
aindriu-aiven/configure-s3-api
branch
from
2a67cc2 to
071992d
Compare
aindriu-aiven
changed the title
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
aindriu-aiven
force-pushed
the
aindriu-aiven/configure-s3-api
branch
from
071992d to
95835f1
Compare
s3-source-connector/src/main/java/io/aiven/kafka/connect/s3/source/utils/AWSV2SourceClient.java
Show resolved
Hide resolved
| @@ -337,13 +339,18 @@ private static byte[] generateNextAvroMessagesStartingFromId(final int messageId | |||
| } | |||
|
|
|||
| private static String writeToS3(final String topicName, final byte[] testDataBytes, final String partitionId) { | |||
| final String objectKey = topicName + "-" + partitionId + "-" + System.currentTimeMillis() + ".txt"; | |||
| final String objectKey = addPrefixOrDefault("") + topicName + "-" + partitionId + "-" | |||
There was a problem hiding this comment.
can we add a prefix to any one of the integration tests and assert for count ?
There was a problem hiding this comment.
The prefix was previously added in the config for the integration tests, but not being used. We are actually using the prefix correctly in our integration tests now.
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Claudenw
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.