Athena driver #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
When POSTing to the `/dataset` endoint, there was code that if the database was our fake database id (used for nested queries) but that same check wasn't present for the dataset exports. This commit adds that check and a test that validates it. Fixes metabase#8256
…sult-metadata Ensure base type in result metadata
The redshift connection configuration details got messed up in the refactor. Instead of the password field a second port field got included. The password field was put back in but the second port field needed to get removed.
Dataset exports should check for nested queries
Add missing Redshift driver password field
…bels Shorter x-ray action labels
* tweak download widget * add updated icons * hover inherit util + download hover state
…ries-ordering xrays: Ensure stable series ordering
…nbinnable Use map display to compare states and countries
…-sorting Don't needlessly re-sort results
Respect :active flag in related and xrays
…print-defaults Use nils in datetime fingerprint as placeholders when all values are nil
…ering Fix template tags reordering while editing
This commit wraps our calls to `i18n/translate` so that if the message isn't a valid Java MessageFormat message, it doesn't crash. It will log the message and return the original (untranslated) string.
Make a fail-safe i18n translate function
Column settings, mini bar charts, and more
…mmary Fix NPE from sync operations logging
…ses-to-before-expansion Query Processor Refactor Part 5
QP refactor part 6 - rework add-dimension-projections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've implemented nested fields (i.e. qualify fields) support. This includes picker and joins.