-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alabama, Hawaii, Louisiana, New Jersey Scrapers #132
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with this!
One thing I identified is that the "locationName" is missing from the physicalAddress or mailingAddress of AL, HI, and LA (only has to be in one or the other, but preferred both when possible).
Also, and perhaps this is nothing, but in the LA scraper, I see that "county_name {county_name} is the culprit gets printed out if there isn't a city in the parsed dict. Is that just debugging?
From Paulo about LA: "Make sure they’re referred to as parishes. They’re distinctively NOT counties"
…a location name and paste the parish to the phrase " Parish Registrar of Voters" Let me know if I need to go further1
…ted, fixed it just now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thing is that the website field is missing from the schema in all the scraper files. I think if those get corrected along with the upper case physicalAddress field values we'll be looking kosher
There's a merge conflict for this one and it looks like you actually were trying to add the website field, but something got messed up while using git. |
Lemme know if I need to fix anything else!
… City/County title; added URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets go to mars
… for County and City), and has web address for each county board of elections
… and yeeted PO Box from New Jersey physical address(Pretty sure they typed it by hand), fixed up Honolulu in HI
… learning opportunity; once this is all over, I'd want to redo this one using the South Dakota Courthouse website
Hey- do I need to do anything else to squash and merge with the main branch? |
Nah, you're good for now. I haven't gotten around to testing it yet, but I should have that done today |
…ized that some don't have periods in between number sequences, and others had hyphens
This closes #94, closes #100, and closes #106, and closes #113