-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete copy constructor and assignment operator for ParticleTile #3943
Delete copy constructor and assignment operator for ParticleTile #3943
Conversation
The Windows CI failure looks like a compiler bug. |
More specifically it complains about We could put the new changes inside |
Note - the WarpX test failure was a problem in WarpX that was uncovered by this change. It's already been fixed in development but is not part of the release yet. |
This has better performance and the change is now necessary because of #3943.
@@ -720,6 +720,16 @@ struct ParticleTile | |||
|
|||
ParticleTile () = default; | |||
|
|||
#ifndef _WIN32 // workaround windows compiler bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atmyers @WeiqunZhang This should probably read MSVC.
There are many compilers on Windows (LLVM/Clang, GCC aka MinGW, Intel, etc.) that should work file :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see that LLVM/Clang failed, too.
This prevents common programming errors involving accidently copying particle tiles.
The proposed changes: