Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amrex::tupleToArray #3880

Merged
merged 2 commits into from
Apr 10, 2024
Merged

amrex::tupleToArray #3880

merged 2 commits into from
Apr 10, 2024

Conversation

WeiqunZhang
Copy link
Member

Add a utility function that can convert an amrex::GpuTuple whose types are the same to an array.

@WeiqunZhang WeiqunZhang force-pushed the make_array branch 3 times, most recently from cae048b to 30d6a00 Compare April 10, 2024 03:05
@WeiqunZhang
amrex::tupleToArray
aa24310 
Add a utility function that can convert an amrex::GpuTuple whose types are
the same to an array.
@AlexanderSinn
Copy link
Member

Looks good! I think constexpr should be added to the functions. Possibly also AMREX_GPU_HOST_DEVICE but that would only make sense if it would return an amrex::GpuArray instead of std::array.

@WeiqunZhang
Copy link
Member Author

Yes, constexpr should be added. As for having it return GpuArray, I thought about it, but wasn't entirely sure if we should do it. Thinking about it again, there is probably not much downside.

@WeiqunZhang WeiqunZhang merged commit 40ed6ef into AMReX-Codes:development Apr 10, 2024
68 of 69 checks passed
@WeiqunZhang WeiqunZhang deleted the make_array branch April 10, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSinn AlexanderSinn AlexanderSinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiqunZhang @AlexanderSinn