-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make clang-tidy recognize .H as a header #3832
make clang-tidy recognize .H as a header #3832
Conversation
hmmm... the version of |
indeed, this option was only added in clang-tidy 17: there must be another way to tell clang-tidy to recognize the headers for old versions. At the moment, clang-tidy is not doing all the checks cause it doesn't treat .H as a header |
We can add this to the config file for now.
|
I tested the |
okay. I'll update the PR |
There will be many errors to fix. Do you want me to help? |
I can help. But I'm working through Castro and Microphysics first. Maybe we hold this for a little bit until the other tidy PRs are all done. |
fyi @lucafedeli88 |
After #3867, we can go back to the first commit of this PR. |
Summary
the output of
clang-tidy --dump-config
shows that .H is not recognized as a headerAdditional background
Checklist
The proposed changes: