Explicit Includes: MultiFab -> BaseFab #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a directly used class as include.
This was referenced Mar 14, 2024
More directly used dependencies.
ax3l
force-pushed
the
fix-missing-include
branch
from
400f216 to
2ad5a8f
Compare
ax3l
changed the title
WeiqunZhang
pushed a commit
that referenced
this pull request
Mar 16, 2024
## Summary Execute the `install` and `test_install` targets in Windows CI, too. ## Additional background Increase coverage, e.g., for issues such as #3798 #3802 ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
WeiqunZhang
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add includes for directly used types.
Additional background
Related to #3798, I was wondering if there might be an missing include to
BaseFab<double>::lockAddandAMReX_OpenMP.Hsomewhere... In the end this is just cleaning.Checklist
The proposed changes: