Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMRES Tutorial #143

Merged
merged 20 commits into from
Dec 3, 2024
Merged

GMRES Tutorial #143

merged 20 commits into from
Dec 3, 2024

Conversation

ajnonaka
Copy link
Contributor

Simple driver and class for unpreconditioned GMRES for Poisson equation.

@ajnonaka
Copy link
Contributor Author

I think I need to change the initial condition to be random (and sum to zero) - it's converging too easily with sin(2 pi x) on the RHS.

@WeiqunZhang
Copy link
Member

I think I have got precon working. Do you want me to push the changes?

@ajnonaka
Copy link
Contributor Author

ajnonaka commented Dec 2, 2024

Sure I was going to ask you about it later today but go ahead and push and I'll study the differences. Thanks!

@WeiqunZhang
Copy link
Member

Maybe we can add some comments to what the preconditioner is supposed to do. It is supposed to solve P(lhs) = rhs, where P is an approximation for A. In the case that no preconditioner is used, P is an identity matrix.

@ajnonaka
Copy link
Contributor Author

ajnonaka commented Dec 2, 2024

yes both in this PR and in the amrex/src... I was going to pull the comments from the classes in there directly into this PR.

@WeiqunZhang
Copy link
Member

It might also be worth mentioning here and in amrex/Src that we use right preconditioning.

@ajnonaka
Copy link
Contributor Author

ajnonaka commented Dec 2, 2024

I'll do a little tidying and merge (later today)

@ajnonaka
Copy link
Contributor Author

ajnonaka commented Dec 2, 2024

And I'll update the documentation.

@ajnonaka ajnonaka merged commit 29f211e into AMReX-Codes:main Dec 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants