Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #708

Merged
merged 14 commits into from
Jan 24, 2025
Merged

Code cleanup #708

merged 14 commits into from
Jan 24, 2025

Conversation

jmafoster1
Copy link
Collaborator

  • Added prettier-plugin-sort-imports plugin to order the imports consistently
  • Added jscodeshift plugins to convert import {Thing} from "@mui/material" imports to import Thing from "@mui/material/Thing"
  • Made both of these part of the pre-commit
  • Ran them both on the Assistant files

If you would like, I can run the new transforms globally to prevent commit noise later on, or we can gradually shift to the new formatting as files get updated.

@jmafoster1 jmafoster1 marked this pull request as ready for review January 24, 2025 11:59
@jmafoster1 jmafoster1 requested a review from Sallaa January 24, 2025 11:59
@Sallaa Sallaa changed the base branch from master to beta-master January 24, 2025 12:09
@Sallaa
Copy link
Contributor

Sallaa commented Jan 24, 2025

Thank you @jmafoster1 -- Yes, you can do a global cleanup. Hopefully it'll be smooth

@jmafoster1
Copy link
Collaborator Author

Global cleanup done. It only took an hour and a half, so not too bad really. I've tried the assistant on a few sites and everything seems to be working as before, but it's a monster of a PR to review!

@Sallaa
Copy link
Contributor

Sallaa commented Jan 24, 2025

Thank you for cleaning up all the files. I went through all the files, tried the main features of the tools, and it is working as before. We really need automated tests 😨

@Sallaa Sallaa merged commit c70adb2 into beta-master Jan 24, 2025
1 check passed
@jmafoster1
Copy link
Collaborator Author

We really need automated tests 😨

Yes, very much so! Did you decide what to do about mocking in #655? I have some time this week before we start on the chat bot integration, so could look into that.

@Sallaa
Copy link
Contributor

Sallaa commented Jan 27, 2025

Unfortunately, not yet, I hope I can give you an answer next week but it may need to wait until the week after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants