Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

204 piecewise linear model plugin from current mean series #464

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

dbenn
Copy link
Collaborator

@dbenn dbenn commented Jan 25, 2025

Hi @mpyat2. There are 3 main additions here:

  1. A piecewise linear model plugin.
  2. A change to the AoV period search plugin to be able to create a piecewise linear model corresponding to the phased binned means of the selected top hit.
  3. A plugin library that implements most of this, and which is used by 1. and 2.

The created model includes fit metrics and extrema and there are regular JUnit tests for the library.

I have refactored quite a lot of the modelling code although I think merge conflicts are confined to the plugin build.xml.

Note that the VeLa script commits are unrelated to the model so feel free to ignore.

@dbenn dbenn added the plug-in Plug-in Development label Jan 25, 2025
@dbenn dbenn added this to the next milestone Jan 25, 2025
@dbenn dbenn requested a review from mpyat2 January 25, 2025 12:16
@dbenn dbenn linked an issue Jan 25, 2025 that may be closed by this pull request
@mpyat2
Copy link
Collaborator

mpyat2 commented Jan 26, 2025

  1. Open a data file (see attached one as an example)
    V965_Cep_PMAK_BJD_simple.tsv.zip
  2. AoV with period range -> Min Period = 0.08, Max Period = 0.09, Resolution= 0.0000001, Bins=10
  3. Select a top hit: P= 0.0850673, click [Create Model]
    Error:
    image
  4. Click the [New Phase Plot] button
  5. Click [Create Model] again
    image
  6. Then return to the 'Raw data' view and zoom
    image
  7. Where are the model points?
    image

@dbenn
Copy link
Collaborator Author

dbenn commented Jan 26, 2025

Investigating.

@dbenn
Copy link
Collaborator Author

dbenn commented Feb 7, 2025

After a distracted week, I have looked at the disappearing model data points again.

This error occur when using the PLF model creation plugin or the AoV plugin in phase plot mode, then returning to raw mode.

The model (and residual) list contains all the model-derived data points, as does the top-level plot view, just not certain zoomed plot portions. The problem would seem to lie with some aspect of the behaviour of the plot model or pane. Other models don't seem to exhibit this problem.

Looking at the AbstractObservationPlotPane's doZoom() method next.

…pon the existence of a phase plot created from a top-hit result.
@dbenn
Copy link
Collaborator Author

dbenn commented Feb 11, 2025

The model data points that are not visible within a particular isolated segment of the plot at a particular zoom level appear to be deterministic, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in Plug-in Development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Piecewise linear model plugin from current mean series
2 participants