Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20 LTS compatible #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Jim-Kerver
Copy link

Hi! I've noticed the macro not working on 4D 20.1 LTS and thought to make it compatible.
I don't know if it is wanted/needed but since I did the work anyway, I thought to open a pull request.

As seen in the last commit, I had to remove the 'sk execute in host database' from the 'Formula from string' command to make it compatible. I had no issues in executing the Macro after this, but it might change the behaviour of testing in a negative way. Since I do not know what the function does exactly, I could replace it with something else and/or test it properly, Sorry about that.

Let me know what you think!

declaring and assigning a variable on a single line is not supported in 20.1 LTS. Same goes for Function Try
For some reason, having the substring logic right inside the Object declaration does not work in v20.1 LTS. Abstracting it into a local variable works fine though.
V20.1 LTS does not have the parameter 'sk execute in host database' for 'Formula from string' command.
Copy link
Contributor

github-actions bot commented Nov 21, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Jim-Kerver
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant