Improve logging #773
Merged
Improve logging #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple loggers were initialized throughout the app with differring config. Replace with calls to the application logger .initialize method. Also adds an application log level which can be set with ANALYTICS_LOG_LEVEL env var.
|
@scottqueen-bixal I like your changes. I went a little farther with it and moved the logger config to a single place, since the app was creating loggers in several different files. Also added an optional env var to set the log level. Take a look and see what you think |
Excellent, with test and all! - This looks good to me if we want to push up and see how it goes on cloud log stream? |
levinmr
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772
When running
cron.jsthe spawned scripts executed were outputing logging was not making its way up to the cloud log stream.This works to update
winstonfor better reporting syntax and includes a new function to handle logger messages, specifically if we have an error to log it as an error.