-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Reporter to output both UA and GA4 data in reports #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ua api sh
rename education env
Multiple loggers were initialized throughout the app with differring config. Replace with calls to the application logger .initialize method. Also adds an application log level which can be set with ANALYTICS_LOG_LEVEL env var.
Improve logging
Update aws sdk
Catch execution errors in index.js and log them appropriately. Remove duplicate log level tags from being output in cron.js Replace missed logger in ua/index.js
Improve logging further
Handle totals correctly when report data is empty
This was
linked to
issues
Feb 8, 2024
Closed
Closed
levinmr
approved these changes
Feb 8, 2024
XavierMetichecchia
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new repo structure places v1, or UA reporting under the
ua
directory and updates the application insrc
to report on v2, or new GA4 data using the BETA Google Data Client.Other changes/updates in this PR includes:
.nvmrc
file for easy node version management in local development.README.md
to reflect impacts from migrationcron.js
to support monorepo set up for running both UA(legacy) and GA4(new) reporter applications<agency>.env
files to support new GA4 propertiesGOOGLE_APPLICATION_CREDENTIALS
knex
file to support reporter testsanalytics_data_ga4
table for GA4 data. UA will continue to useanalytics_data
tablereports/
,api.json
, reports.json
, andusa.json
to use GA4 query schema and allowed valuessrc/*
to handle changes in Google Data Client API requirementsv1
app and moves the app into theua
directory