refactor deployment #730
Merged
refactor deployment #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryanwoldatwork
commented
Jan 5, 2024
ryanwoldatwork
commented
- use circle ci to run tests, install npm, and push the built project
* don't overwrite config.js * refactor jobs * .cfignore - don't push these files to cloud foundry
* rm todo.txt
* the app is built in CI, then deployed
* per newrelic logging: the newrelic module must be the first module required
* winston isn't loaded yet
ryanwoldatwork
commented
Jan 5, 2024
| @@ -1,6 +1,6 @@ | |||
| version: 2.1 | |||
| jobs: | |||
| develop_deploy: | |||
| run_tests: | |||
There was a problem hiding this comment.
runs tests for every build
ryanwoldatwork
commented
Jan 5, 2024
| @@ -26,11 +26,23 @@ jobs: | |||
| name: run tests | |||
| command: npm test | |||
|
|
|||
|
|
|||
| develop_deploy: | |||
There was a problem hiding this comment.
separate deploys for develop, staging, and production.
the repeated steps can be DRY'd up later
ryanwoldatwork
commented
Jan 5, 2024
| # name: run tests | ||
| # command: npm test | ||
|
|
||
| - run: |
There was a problem hiding this comment.
also not cp'ing cloudgov configs, to overwrite
ryanwoldatwork
commented
Jan 5, 2024
| @@ -2,20 +2,19 @@ if (process.env.NODE_ENV !== 'production') { | |||
| require('dotenv').config() | |||
| } | |||
|
|
|||
| if (process.env.NEW_RELIC_APP_NAME) { | |||
There was a problem hiding this comment.
loading new relic before winston, because 1. winston was having issues and 2. new relic's agent was complaining about not being loaded first (not being loaded before winston)
* many .env files live in /deploy/envs/
scottqueen-bixal
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.