feat: update workers service in proxy #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantiagoPittella
force-pushed
the
santiagopittella-update-workers-endpoint-in-proxy
branch
from
45c7cfb to
671e116
Compare
bobbinth
requested changes
Jan 25, 2025
bobbinth
approved these changes
Jan 28, 2025
fix: move changelog entry to right place
SantiagoPittella
force-pushed
the
santiagopittella-update-workers-endpoint-in-proxy
branch
from
87dd71d to
5353d9d
Compare
igamigo
approved these changes
Jan 28, 2025
| WORKER_UNHEALTHY.inc_by(unhealthy_workers as u64); | ||
|
|
||
| // Sleep for the defined interval before the next health check | ||
| sleep(self.health_check_frequency).await; |
There was a problem hiding this comment.
nit: It sounds like this is not the frequency (ie, health checks per unit of time) but more like an interval or period so maybe the variable can be renamed
SantiagoPittella
deleted the
santiagopittella-update-workers-endpoint-in-proxy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new service to the proxy server, which is in charge of updating the workers in the load balancer. This allows of removing the responsibility from the proxy itself.
closes #1003