Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note inputs in the advice provider #600

Closed
bobbinth opened this issue Apr 11, 2024 · 1 comment
Closed

Note inputs in the advice provider #600

bobbinth opened this issue Apr 11, 2024 · 1 comment
Assignees
@hackaugusto
Labels
enhancement New feature or request kernels Related to transaction, batch, or block kernels refactoring Code clean-ups, improvements, and refactoring
Milestone
v0.4

Comments

@bobbinth
Copy link
Contributor

Currently, note inputs in the advice provider are stored as:

commitment |-> padded_inputs

This means that by looking up inputs, it is not possible to tell what is the actual number of inputs for a given note. This leads to problems like in #598.

We should change the format to store inputs as follows:

commitment |-> [num_inputs, padded_inputs]

This will eliminate the need for storing padded and un-padded inputs under different keys.
@bobbinth bobbinth added enhancement New feature or request kernels Related to transaction, batch, or block kernels refactoring Code clean-ups, improvements, and refactoring labels Apr 11, 2024
@bobbinth bobbinth added this to the v0.3 milestone Apr 11, 2024
@Dominik1999 Dominik1999 moved this to In Review in User's testnet Apr 22, 2024
@bobbinth bobbinth modified the milestones: v0.3, v0.4 May 12, 2024
@hackaugusto hackaugusto mentioned this issue May 23, 2024
Merged
hackaugusto added a commit that referenced this issue May 27, 2024
@hackaugusto
fix #600
cbca074
@hackaugusto hackaugusto mentioned this issue May 27, 2024
Merged
hackaugusto added a commit that referenced this issue May 27, 2024
@hackaugusto
fix #600
37d9765
hackaugusto added a commit that referenced this issue May 29, 2024
@hackaugusto
fix #600
6f1a03c
hackaugusto added a commit that referenced this issue May 31, 2024
@hackaugusto
fix #600
bc65dfe
hackaugusto added a commit that referenced this issue May 31, 2024
@hackaugusto
fix #600
7ff230d
hackaugusto added a commit that referenced this issue May 31, 2024
@hackaugusto
fix #600
1d1f893
hackaugusto added a commit that referenced this issue May 31, 2024
@hackaugusto
fix #600
bcf8167
hackaugusto added a commit that referenced this issue May 31, 2024
@hackaugusto
fix #600
e9c8ea0
hackaugusto added a commit that referenced this issue May 31, 2024
@hackaugusto
fix #600
bf3109b
@bobbinth
Copy link
Contributor Author

Closed by #707.

@github-project-automation github-project-automation bot moved this from In Review to Done in User's testnet May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackaugusto hackaugusto

Labels
enhancement New feature or request kernels Related to transaction, batch, or block kernels refactoring Code clean-ups, improvements, and refactoring
Projects
User's testnet
Status: Done
Milestone
v0.4
Development

No branches or pull requests
2 participants
@hackaugusto @bobbinth