Fix issue 600

[hackaugusto]

fixes #600

• Removes the inputs length from the NULLIFIER_COMMITMENT, since now it is available in the INPUTS_HASH
• Removes the difference among consumed/created notes' inputs, now both encode the inputs prefixed by its length and padded to an even number of words
• Add the length as the first element to the INPUTS_HASH
• Update some of the documentation which was out of date

[hackaugusto]

This was out-of-date, the NOTE_ROOT is much deeper in the advice stack:

miden-base/miden-lib/asm/miden/kernels/tx/prologue.masm

Lines 920 to 935 in 74a5371

	#! Advice stack: [
	#! PREVIOUS_BLOCK_HASH,
	#! CHAIN_MMR_HASH,
	#! ACCOUNT_ROOT,
	#! NULLIFIER_ROOT,
	#! BATCH_ROOT,
	#! PROOF_HASH,
	#! [block_num, version, timestamp, 0],
	#! ZERO,
	#! NOTE_ROOT,
	#! [account_id, 0, 0, account_nonce],
	#! ACCOUNT_VAULT_ROOT,
	#! ACCOUNT_STORAGE_ROOT,
	#! ACCOUNT_CODE_ROOT,
	#! number_of_input_notes,
	#! TX_SCRIPT_ROOT,

Instead of copying and pasting the docs, I added a reference to prepare_transaction

[hackaugusto]

The num_inputs is now defined in the advice map, these are no longer needed

[hackaugusto]

Note: I think these APIs should change to pass an explict idx, it would make testing possible.

[bobbinth]

Looks good! Thank you! I left some comments inline - most of these are pretty small.

applied requested changes, please re-review

[bobbinth]

Looks good! Thank you! I left a couple more minor comments inline. After these are resolved, we can merge.

[bobbinth]

Oh - and let's update changelog.

[hackaugusto]

Oh - and let's update changelog.

Added

[bobbinth]

All looks good! Thank you!