Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter improvements (sizes and addresses) #472

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

mappzor
Copy link
Contributor

@mappzor mappzor commented Jan 11, 2024

  1. Replaced stack_width -> address_width to prevent trimming real values in some situation (address size overrides)
  2. Print agen sizes (in forced mode only) -> affects lea and some bnd* instructions, mib behavior unchanged because we don't have standardized names for such sizes anyway

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@athre0z athre0z merged commit 03b7723 into zyantific:master Jan 14, 2024
13 checks passed
@mappzor mappzor deleted the formatter branch January 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants