Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative URLs for images #498

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Support relative URLs for images #498

merged 2 commits into from
Feb 3, 2025

Conversation

AdrianMachado
Copy link
Contributor

@AdrianMachado AdrianMachado commented Feb 3, 2025

Images in our docs are broken. The CDN links are missing the /docs portion prior to the /media. I think this only affects pages that do ../../public... for their images paths like the getting started guide.

I hope this aligns with the changes @ntotten wanted to make here

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 7:55pm

@AdrianMachado AdrianMachado requested review from dan-lee and ntotten and removed request for dan-lee February 3, 2025 19:54
@AdrianMachado AdrianMachado marked this pull request as ready for review February 3, 2025 19:55
@AdrianMachado AdrianMachado requested a review from mosch February 3, 2025 19:55
@AdrianMachado AdrianMachado changed the title Support relative URLs Support relative URLs for images Feb 3, 2025
@AdrianMachado AdrianMachado merged commit 8137507 into main Feb 3, 2025
8 checks passed
@AdrianMachado AdrianMachado deleted the fixImages branch February 3, 2025 20:04
Copy link
Contributor

@mosch mosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed & Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants