Copy Data set bug + DeferredPromise format fix #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/cli/__tests__/zosfiles/__unit__/copy/ds/Ds.handler.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/cli/__tests__/zosfiles/__unit__/copy/ds/Ds.handler.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/cli/__tests__/zosfiles/__unit__/copy/ds/Ds.handler.unit.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
pujal0909
force-pushed
the
copy-ds-bug
branch
from
f436109 to
484775d
Compare
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
pujal0909
force-pushed
the
copy-ds-bug
branch
from
563565c to
af98302
Compare
…AM.ams.temp Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
…AM.ams.temp Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2413 +/- ##
==========================================
+ Coverage 91.34% 91.35% +0.01%
==========================================
Files 639 639
Lines 18259 18269 +10
Branches 3949 3844 -105
==========================================
+ Hits 16678 16690 +12
+ Misses 1579 1577 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
pujal0909
force-pushed
the
copy-ds-bug
branch
from
77b74c5 to
37c02a5
Compare
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
pujal0909
changed the title
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
|
📅 Suggested merge-by date: 1/31/2025 |
pujal0909
requested review from
gejohnston,
zFernand0,
awharn,
traeok,
anaxceron,
ATorrise,
adam-wolfe,
t1m0thyj and
jace-roell
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
anaxceron
approved these changes
Jan 21, 2025
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
gejohnston
approved these changes
Jan 23, 2025
|
Reminder: This pull request has a merge-by date coming up within the next 24 hours. Please review this PR as soon as possible. @t1m0thyj @zFernand0 @awharn @traeok @jace-roell @ATorrise @adam-wolfe |
traeok
approved these changes
Jan 29, 2025
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
zFernand0
requested changes
Jan 29, 2025
...__/zosfiles/__integration__/copy/ds/__snapshots__/cli.files.copy.ds.integration.test.ts.snap
Show resolved
Hide resolved
packages/imperative/src/utilities/__tests__/DeferredPromise.unit.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
zFernand0
reviewed
Jan 29, 2025
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
zFernand0
approved these changes
Jan 29, 2025
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
|
Thanks for fixing the snapshots. 🥳 |
|
zFernand0
added
the
release-current
awharn
reviewed
Jan 30, 2025
| }, | ||
| { | ||
| name: "safe-replace", | ||
| aliases: ["safe-rep", "--sr"], |
There was a problem hiding this comment.
I believe the alias should be sr, not --sr.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
#2369
Added a new --safe-replace (--safe-rep) option to the copy command that prompts users to confirm whether they want to overwrite the contents of the target data set.
Also, made a small format fix on the DeferredPromise.ts and DeferredPromise.unit.test files.
How to Test
Use the --safe-replace flag with the copy command. A prompt will appear, where you can respond with "y/N".
zowe zos-files copy ds "data-set1" "data-set2" --safe-replace
Review Checklist
I certify that I have:
Additional Comments