-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download record range flag #2411
Conversation
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
📅 Suggested merge-by date: 1/29/2025 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2411 +/- ##
=======================================
Coverage 91.35% 91.36%
=======================================
Files 639 639
Lines 18269 18283 +14
Branches 3844 3850 +6
=======================================
+ Hits 16690 16704 +14
Misses 1577 1577
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested an extra confirmation for some of your tests.
Give some consideration to whether it would be helpful.
Either way I approve this PR.
Signed-off-by: jace-roell <jace.roell@hotmail.com>
|
Reminder: This pull request has a merge-by date coming up within the next 24 hours. Please review this PR as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and functionality LGTM, thanks Jace!
I'm wondering if we should support for this argument to the zowe jobs view spool-file-by-id
command as well? CLI users will likely want the record range for a specific job spool rather than for all spool files. For example, let's say you want to get the record range "50-75" for the 3rd spool file in the job - when running the download command w/ record range, that range doesn't exist for the 2nd spool file, so it returns an error:
Since we use GetJobs.getSpoolContentById
instead of DownloadJobs.downloadSpoolContentCommon
for that command though, it may involve some refactoring, and I don't want to add scope creep. Curious to get your thoughts on this @adam-wolfe, this could be addressed separately if we want to avoid increasing scope - I will approve the PR for now as this behavior is valid when expecting a record range that doesn't exist for all spool files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality LGTM! 😋
Can we add an example of this new option?
Also...
Not sure if this is fixed on another PR already, but...
I'm getting these file changes (mostly license headers being updated being)
On branch download-record-range
Your branch is up to date with 'origin/download-record-range'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: packages/imperative/src/utilities/__tests__/DeferredPromise.unit.test.ts
modified: packages/imperative/src/utilities/src/DeferredPromise.ts
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Thanks for addressing the feedback so quickly 🙏
Just waiting for CI to finish.
Then lets have a merge-party and combine a few PRs 🥳
Be on the lookout for unit and integration test snapshots 😋
…ad-record-range Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What It Does
Added --recordRange to
zowe jobs download output
commandHow to Test
Run command 'zowe jobs download o "" --rr "0-100"` against a valid job
Where 0 is the start of the spool and 100 is the end (zero-indexed)
Review Checklist
I certify that I have: