Fix for compare sequence numbers and online help #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KevinLoesch1 <kevin.loesch@broadcom.com>
Signed-off-by: KevinLoesch1 <kevin.loesch@broadcom.com>
KevinLoesch1
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
ATorrise and
adam-wolfe
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1993 +/- ##
=======================================
Coverage 91.03% 91.03%
=======================================
Files 636 636
Lines 18718 18720 +2
Branches 3900 3901 +1
=======================================
+ Hits 17040 17042 +2
Misses 1677 1677
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: KevinLoesch1 <kevin.loesch@broadcom.com>
gejohnston
approved these changes
Dec 20, 2023
Signed-off-by: KevinLoesch1 <kevin.loesch@broadcom.com>
…/zowe/zowe-cli into Fix-for-compare-sequence-numbers
zFernand0
approved these changes
Jan 2, 2024
packages/cli/__tests__/zosfiles/__unit__/compare/ds/Dataset.handler.unit.test.ts
Outdated
Show resolved
Hide resolved
t1m0thyj
reviewed
Jan 3, 2024
Signed-off-by: KevinLoesch1 <kevin.loesch@broadcom.com>
Signed-off-by: KevinLoesch1 <kevin.loesch@broadcom.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
This pull request corrects two bugs. The first one is to correct the output and compare when zowe files compare is issued on Windows and the --noseq false option is specified. The second fix is for the zowe files compare online help.
#1754
#1992
How to Test
Run zowe files compare with the --noseq false on Windows against files that have sequence numbers. The first sequence number should not be the last character of the line.
Review Checklist
I certify that I have: