Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Linux dev. pre-requisites to README #1989

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

traeok
Copy link
Member

@traeok traeok commented Dec 14, 2023

What It Does

This PR adds instructions to install the required development packages to build Zowe CLI from source, namely for developers running Linux.

These packages are needed to compile the Secrets SDK on Linux distributions.

How to Test

  • On Linux, install the packages in the README section "Building Zowe CLI from source"
  • Once those packages have been installed, try to build the repository: npm install && npm run build

Review Checklist
I certify that I have:

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd55a9e) 91.03% compared to head (e6e2b89) 91.03%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1989   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         636      636           
  Lines       18718    18718           
  Branches     3900     3900           
=======================================
  Hits        17040    17040           
  Misses       1677     1677           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@traeok traeok merged commit 0c94a42 into master Dec 14, 2023
19 checks passed
@traeok traeok deleted the chore/secrets-linux-deps branch December 14, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants