Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tsconfigs to test folders to reduce jest type errors in vscode #1982

Closed
wants to merge 10 commits into from

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented Nov 30, 2023

What It Does
Configures typescript test files to include jest type information, reducing the amount of distracting, not-real-yet-still-highlighted-as-such errors when working in test files

How to Test
Pull branch and start opening up some test files, making sure there are no errors like:

Cannot find name 'describe'. Do you need to install type definitions for a test runner? Try `npm i --save-dev @types/jest` or `npm i --save-dev @types/mocha`.ts(2582) 

Review Checklist
I certify that I have:

Additional Comments
Each tsconfig file includes the following section:

"include": [
  "../**/*.ts"
]

This provides any .ts file in any directory within the parent directory information on jest types

Signed-off-by: Amber Torrise <at895452@broadcom.net>
…y created tsconfigs

Signed-off-by: Amber Torrise <at895452@broadcom.net>
@ATorrise ATorrise self-assigned this Nov 30, 2023
@ATorrise ATorrise requested a review from adam-wolfe November 30, 2023 18:59
Amber Torrise added 6 commits December 8, 2023 12:54
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35a82d7) 91.03% compared to head (1502193) 91.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1982   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         635      635           
  Lines       18608    18608           
  Branches     3859     3859           
=======================================
  Hits        16939    16939           
  Misses       1668     1668           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Amber Torrise added 2 commits December 13, 2023 10:20
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
@ATorrise ATorrise closed this Jan 2, 2024
@ATorrise ATorrise deleted the tsconfig_jest branch February 13, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant