ConfigSecure.securePropsForProfile may return properties for wrong profile

[t1m0thyj]

correction, it's this.mConfig.api.secure.securePropsForProfile instead of ConfigUtils.getActiveProfileName that causes an issue.

it still happens to me after syncing with next this morning. i dont get an issue using @t1m0thyj's sample profile with lpar1.zosmf and lpar2.zosmf, but i do get an issue with lpar1.zosmf and lpar1.zosmf2 as in my example.

two instances of zosmf on the sample lpar2 don't make sense, but i the lpar higher level is an arbitrary construction.

Here is the code with trace messages added:

    public securePropsForProfile(profileName: string) {
        console.log(`>>>> entry <<<<`)
        const profilePath = this.mConfig.api.profiles.expandPath(profileName);
        console.log(`profilePath: ${profilePath}`)
        const secureProps = [];
        for (const propPath of this.secureFields()) {
            console.log(`propPath: ${propPath}`)
            const pathSegments = propPath.split(".");  // profiles.XXX.properties.YYY
            // eslint-disable-next-line @typescript-eslint/no-magic-numbers
            if (profilePath.startsWith(pathSegments.slice(0, -2).join("."))) {
                secureProps.push(pathSegments.pop());
            }
        }
        console.log(`secureProps ${secureProps}`)
        console.log(`>>>> exit <<<<`)
        return secureProps;
    }

here's the command i run and output I see:

C:\dev\systems\ca11>zowe jobs list jobs --show-inputs-only --zosmf-p lpar1.zosmf2
>>>> entry <<<<
profilePath: profiles.lpar1.profiles.zosmf2
propPath: profiles.lpar1.profiles.zosmf.properties.host
propPath: profiles.my_base.properties.user
propPath: profiles.my_base.properties.password
secureProps host
>>>> exit <<<<
>>>> entry <<<<
profilePath: profiles.my_base
propPath: profiles.lpar1.profiles.zosmf.properties.host
propPath: profiles.my_base.properties.user
propPath: profiles.my_base.properties.password
secureProps user,password
>>>> exit <<<<

it looks like zosmf2 becomes zosmf in ConfigProfiles.expandPath

Originally posted by @dkelosky in zowe/imperative#721 (comment)

[t1m0thyj]

Fixed by #2016

Tested with the sample profiles provided by @dkelosky

        "lpar1": {
            "properties": {
                "host": "usilca11.lvn.broadcom.net"
            },
            "profiles": {
                "zosmf": {
                    "type": "zosmf",
                    "properties": {
                        "port": 1443
                    },
                    "secure": [
                        "host"
                    ]
                },
                "zosmf2": {
                    "type": "zosmf",
                    "properties": {
                        "port": 1443
                    },
                    "secure": []
                },

Old Output

$ zowe jobs list jobs --show-inputs-only --zosmf-p lpar1.zosmf2
>>>> entry <<<<
profilePath: profiles.lpar1.profiles.zosmf2
propPath: profiles.lpar1.profiles.zosmf.properties.host
propPath: profiles.my_base.properties.user
propPath: profiles.my_base.properties.password
secureProps host
>>>> exit <<<<
>>>> entry <<<<
profilePath: profiles.my_base
propPath: profiles.lpar1.profiles.zosmf.properties.host
propPath: profiles.my_base.properties.user
propPath: profiles.my_base.properties.password
secureProps user,password
>>>> exit <<<<

New Output

$ zdev jobs list jobs --show-inputs-only --zosmf-p lpar1.zosmf2
>>>> entry <<<<
profilePath: profiles.lpar1.profiles.zosmf2
propPath: profiles.lpar1.profiles.zosmf.properties.host
propPath: profiles.base.properties.user
propPath: profiles.base.properties.password
secureProps 
>>>> exit <<<<
>>>> entry <<<<
profilePath: profiles.base
propPath: profiles.lpar1.profiles.zosmf.properties.host
propPath: profiles.base.properties.user
propPath: profiles.base.properties.password
secureProps user,password
>>>> exit <<<<

We still iterate over the same properties, but host is now ignored since it comes from a different profile.