ZMS-187: Rewrite addMessage, moveMessage to async/await #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andris9
requested changes
Feb 6, 2025
andris9
requested changes
Feb 14, 2025
NickOvt
changed the title
andris9
requested changes
Feb 19, 2025
|
Running same tests locally on v18 node results in positive result. |
andris9
requested changes
Feb 21, 2025
… functions outside
andris9
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addAsyncrewriteaddto use async/await.moveAsyncrewritemoveto use async/await.Previously they were fully callback based, which made it harder to read and understand. Current changes should have improved the readibility as it made code more linear.
There are still some function-in-function spots, that may be fixed with later commits and more thorough refactoring.