Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#14: Avoid using root ruby.h #32

Closed
wants to merge 2 commits into from
Closed

#14: Avoid using root ruby.h #32

wants to merge 2 commits into from

Conversation

DronMDF
Copy link
Contributor

@DronMDF DronMDF commented Dec 25, 2018

This file is not on appveyor images.

Try to use includes from ruby subdirectory.

By issue #14.

@DronMDF
zold-io#14: Avoid using root ruby.h
b8768cd 
This file is not on appveyor images.
@0crat
Copy link

0crat commented Dec 25, 2018

@DronMDF this pull request is too small, just 2 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @yegor256/z please review this and merge or reject

@DronMDF DronMDF force-pushed the master branch 2 times, most recently from cd6582d to 2a729be Compare December 25, 2018 19:00
@DronMDF DronMDF closed this Dec 25, 2018
@0crat
Copy link

0crat commented Dec 25, 2018

Job gh:zold-io/zold-score#32 is not assigned, can't get performer

@0crat
Copy link

0crat commented Dec 25, 2018

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DronMDF @0crat