Updated NPM Script To Add Specmatic.jar Before Packaging #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeepk
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR modifies the download sequence of specmatic.jar in the Specmatic NPM package. Instead of downloading specmatic.jar after the package installation (using a postinstall script), the jar file is now downloaded before the package is packed (using a prepack script).
Why:
The modification ensures that specmatic.jar is bundled within the package at the time of packing. This approach helps to avoid potential issues where the jar file might not be correctly included when the package is installed.
How:
The implementation involved switching from a postinstall script to a prepack script in the package.json file. This script handles the downloading of specmatic.jar and ensures it is added to the correct directory before the package is packed.