Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEMIT for llava #463

Open
LiuJinzhe-Keepgoing opened this issue Dec 27, 2024 · 2 comments
Open

MEMIT for llava #463

LiuJinzhe-Keepgoing opened this issue Dec 27, 2024 · 2 comments
Labels
question Further information is requested

Comments

@LiuJinzhe-Keepgoing
Copy link

Hello, can I ask if MEMIT can be applied to the editing of multimodal models? For example, editing the LLAVA model through MEMIT? Do you have any plans to realize this function?

@zxlzr zxlzr added the question Further information is requested label Dec 27, 2024
@tbozhong
Copy link
Collaborator

tbozhong commented Jan 8, 2025

Hi there,

MEMIT can be applied to the editing of multimodal models. However, in our experience, it tends to show subpar editing performance. This is because MEMIT requires a last_subject_token in the triple (subject, relation, object) to edit, but VQA or caption data do not contain such triples (especially in caption data). As a workaround, we used the last_token instead, but this approach was unsuccessful.

If you have any suggestions or ideas on how to improve this, we welcome PRs to EasyEdit!

@zxlzr
Copy link
Contributor

zxlzr commented Jan 24, 2025

Hi, do you have any further questions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants