Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'offline' mode #47

Closed
nachog00 opened this issue Jan 21, 2025 · 3 comments
Closed

Add 'offline' mode #47

nachog00 opened this issue Jan 21, 2025 · 3 comments

Comments

@nachog00
Copy link
Contributor

It might be worthwhile to add an offline mode. That is, to allow devs to shut off the fetcher logic completely.

If they are bringing in their own binaries, we should't be slowing them down with async fetching and potentially slow verifying of hashes on every build.

@ala-mode
Copy link
Contributor

ala-mode commented Jan 21, 2025

I agree. Verifying shouldn't take too long, but fetching can be resource intensive. Not sure about an exact design but maybe if (all?) binaries are specified, the user would get a message (maybe we should add a message for when we are fetching binaries too?) and bypass fetching completely. Also it makes sense to not fetch for any reason if the user passes an argument to accomplish this.

I think we would want a command line flag or similar. How can we hook our build script into such a technique?

@zancas zancas transferred this issue from another repository Feb 12, 2025
@ala-mode
Copy link
Contributor

simply pasting in comments from #24 (duplicate issue) ....

nachog00 :
If connection completely off, binaries cannot be downloaded.
We need to warn the user and prompt them to either fix their connection or turn on fetcher's offline mode

ala-mode :
IIRC the message a user gets while offline is a DNS error or something similar. I agree we should have a more informative (error?) message.

@nachog00
Copy link
Contributor Author

With fetcher-core (#31 ), an 'offline mode' doesn't make sense anymore, I think. Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants