-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetching timeout config #23
Comments
Check out this line and the one right below it. Right now this is hard coded, but as a feature we could add config for this. I think this is low priority. |
Those are just for connection and beginning to write. As far as having timeouts for established connections set, I'm not sure, but I made this comment which states the socket lasts 90 seconds. I'm not sure this is exactly what you're asking for, or if there's a convenient interface for that. |
Ok, it being defined in the codebase makes it less obscure than, let's say, it coming from some default from some dep. I still think we might want to make this configurable by the consumer, as users with slow connections might still want to wait it out and use the tool, but get blocked by this. What do you think @ala-mode ? I agree that it isn't highest priority tho. |
Yeah, absolutely. I think there should be a number of config options and this could be one of them. See #35 - it might talk about some of these too. |
On slow connections, fetching the binaries times out.
The specific timeout time isn't defined on out codebase (I think (?)).
Let's try and make it more explicit and maybe even configurable to the end user through env vars (or something else).
The text was updated successfully, but these errors were encountered: