Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopwords Fix PR #1012

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Stopwords Fix PR #1012

wants to merge 15 commits into from
+147 −11

Conversation

sania-16
Copy link
Contributor

@sania-16 sania-16 commented Jan 21, 2025 •
edited
Loading

issue #1002

sonalgoyal
sonalgoyal reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@sonalgoyal sonalgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see changes

common/client/src/main/java/zingg/common/client/util/DSUtil.java Outdated Show resolved Hide resolved
common/core/src/main/java/zingg/common/core/executor/ZinggBase.java Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 29, 2025
View reviewed changes
common/client/src/main/java/zingg/common/client/HasStopWords.java
Comment on lines +8 to +13
if(!(f.getStopWords() == null || f.getStopWords() == "")){
return true;
}
else {
return false;
}

Check warning

Code scanning / PMD

This if statement can be replaced by `return {condition};`

This if statement can be replaced by `return {condition};`
common/client/src/main/java/zingg/common/client/util/DSUtil.java Fixed Show fixed Hide fixed
common/client/src/main/java/zingg/common/client/util/StopWordFieldDefUtility.java Fixed Show fixed Hide fixed
common/client/src/test/java/zingg/common/client/util/TestStopWordFieldDefUtility.java Fixed Show fixed Hide fixed
common/client/src/test/java/zingg/common/client/util/TestStopWordFieldDefUtility.java Fixed Show fixed Hide fixed
spark/core/src/test/java/zingg/spark/core/util/TestDSUtil.java Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalgoyal sonalgoyal sonalgoyal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sania-16 @sonalgoyal