Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace instances of space with adUnit where needed #230

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Replace instances of space with adUnit where needed #230

merged 2 commits into from
Jul 25, 2024

Conversation

msub2
Copy link
Contributor

@msub2 msub2 commented Jul 24, 2024

Replaces instances of "space" with "ad unit" where applicable, save for the beacon package which is currently not in use.

limbofeather
limbofeather approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@limbofeather limbofeather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think there's a conflict with the r3f README but otherwise looks good

@msub2 msub2 merged commit 58bbaf5 into main Jul 25, 2024
2 checks passed
@msub2 msub2 deleted the space-adunit branch July 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limbofeather limbofeather limbofeather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msub2 @limbofeather