Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#194: calculate total number of code reviews #339

Merged
merged 1 commit into from
Sep 17, 2024
Merged

#194: calculate total number of code reviews #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions judges/quantity-of-deliverables/count-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ expected:
- /fb/f[total_issues_created != 0]
- /fb/f[total_pulls_submitted != 0]
- /fb/f[total_releases_published != 0]
- /fb/f[total_reviews_submitted = 0]
10 changes: 10 additions & 0 deletions judges/quantity-of-deliverables/quantity-of-deliverables.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,14 @@
!json[:draft] && json[:published_at] && json[:published_at] > f.since
end
end

# Total number of code reviews in all repositories from since
f.total_reviews_submitted =
Fbe.unmask_repos.sum do |repo|
Fbe.octo.pull_requests(repo, state: 'all').sum do |pr|
Fbe.octo.pull_request_reviews(repo, pr[:number]).count do |review|
review[:submitted_at] && review[:submitted_at] > f.since
end
end
end
end
182 changes: 182 additions & 0 deletions test/judges/test-quantity-of-deliverables.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ def test_counts_commits
'https://api.github.com/repos/foo/foo/releases?per_page=100',
body: [{ id: 1, draft: false, published_at: Time.parse('2024-08-01 21:00:00 UTC') }]
)
stub_github('https://api.github.com/repos/foo/foo/pulls?per_page=100&state=all', body: [])
fb = Factbase.new
Time.stub(:now, Time.parse('2024-08-12 21:00:00 UTC')) do
load_it('quantity-of-deliverables', fb)
Expand Down Expand Up @@ -137,6 +138,7 @@ def test_processes_empty_repository
'https://api.github.com/repos/foo/foo/releases?per_page=100',
body: [{ id: 1, draft: false, published_at: Time.parse('2024-08-01 21:00:00 UTC') }]
)
stub_github('https://api.github.com/repos/foo/foo/pulls?per_page=100&state=all', body: [])
fb = Factbase.new
Time.stub(:now, Time.parse('2024-08-12 21:00:00 UTC')) do
load_it('quantity-of-deliverables', fb)
Expand Down Expand Up @@ -188,6 +190,7 @@ def test_quantity_of_deliverables_total_releases_published
{ id: 55, draft: false, published_at: Time.parse('2024-08-11 21:00:00 UTC') }
]
)
stub_github('https://api.github.com/repos/foo/foo/pulls?per_page=100&state=all', body: [])
fb = Factbase.new
f = fb.insert
f.what = 'pmp'
Expand All @@ -202,4 +205,183 @@ def test_quantity_of_deliverables_total_releases_published
assert_equal(7, f.total_releases_published)
end
end

def test_quantity_of_deliverables_total_reviews_submitted
WebMock.disable_net_connect!
stub_github(
'https://api.github.com/repos/foo/foo',
body: { id: 42, full_name: 'foo/foo', open_issues: 0, size: 100 }
)
stub_github(
'https://api.github.com/repos/foo/foo/commits?per_page=100&since=2024-08-02T21:00:00%2B00:00',
body: []
)
stub_github(
'https://api.github.com/repos/foo/foo/issues?per_page=100&since=%3E2024-08-02',
body: [{ pull_request: {} }]
)
stub_github('https://api.github.com/repos/foo/foo/releases?per_page=100', body: [])
stub_github(
'https://api.github.com/repos/foo/foo/pulls?per_page=100&state=all',
body: [
{
id: 2_072_543_249,
number: 100,
state: 'closed',
locked: false,
title: '#50: something title',
user: { login: 'yegor256', id: 526_301, type: 'User' },
body: 'Closes #50',
created_at: Time.parse('2024-08-07 09:32:49 UTC'),
updated_at: Time.parse('2024-08-07 21:06:23 UTC'),
closed_at: Time.parse('2024-08-07 21:05:34 UTC'),
merged_at: Time.parse('2024-08-07 21:05:34 UTC'),
merge_commit_sha: '0527cc188b0495e',
draft: false,
head: {
label: 'yegor256:50', ref: '50', sha: '0527cc188b049',
user: { login: 'yegor256', id: 526_301, type: 'User' },
repo: { id: 100_010, full_name: 'yegor256/repo' }
},
base: {
label: 'zerocracy:master', ref: 'master', sha: '4643eb3c7a0ccb3c',
user: { login: 'zerocracy', id: 24_234_201, type: 'Organization' },
repo: { id: 99_999, full_name: 'zerocracy/repo' }
}
},
{
id: 2_072_543_245,
number: 90,
state: 'open',
locked: false,
title: '#45: something title',
user: { login: 'yegor256', id: 526_301, type: 'User' },
body: 'Closes #45',
created_at: Time.parse('2024-08-02 09:32:49 UTC'),
updated_at: Time.parse('2024-08-02 10:06:23 UTC'),
closed_at: nil,
merged_at: nil,
merge_commit_sha: '0627cc188b0497e',
draft: false,
head: {
label: 'yegor256:45', ref: '45', sha: '1527cc188b040',
user: { login: 'yegor256', id: 526_301, type: 'User' },
repo: { id: 100_010, full_name: 'yegor256/repo' }
},
base: {
label: 'zerocracy:master', ref: 'master', sha: '5643eb3c7a0ccb3b',
user: { login: 'zerocracy', id: 24_234_201, type: 'Organization' },
repo: { id: 99_999, full_name: 'zerocracy/repo' }
}
},
{
id: 2_072_543_240,
number: 85,
state: 'closed',
locked: false,
title: '#30: something title',
user: { login: 'yegor256', id: 526_301, type: 'User' },
body: 'Closes #30',
created_at: Time.parse('2024-08-01 09:32:49 UTC'),
updated_at: Time.parse('2024-08-01 10:06:23 UTC'),
closed_at: Time.parse('2024-08-02 10:06:23 UTC'),
merged_at: nil,
merge_commit_sha: '0627cc188b0497e',
draft: false,
head: {
label: 'yegor256:30', ref: '30', sha: '1527cc188b085',
user: { login: 'yegor256', id: 526_301, type: 'User' },
repo: { id: 100_010, full_name: 'yegor256/repo' }
},
base: {
label: 'zerocracy:master', ref: 'master', sha: '5643eb3c7a0ccb3b',
user: { login: 'zerocracy', id: 24_234_201, type: 'Organization' },
repo: { id: 99_999, full_name: 'zerocracy/repo' }
}
}
]
)
stub_github(
'https://api.github.com/repos/foo/foo/pulls/100/reviews?per_page=100',
body: [
{
id: 22_449_300, body: 'Some text 1',
user: { login: 'yegor257', id: 526_302, type: 'User' },
state: 'CHANGES_REQUESTED', author_association: 'CONTRIBUTOR',
submitted_at: Time.parse('2024-08-07 12:00:10 UTC')
},
{
id: 22_449_250, body: 'Some text 2',
user: { login: 'yegor257', id: 526_302, type: 'User' },
state: 'CHANGES_REQUESTED', author_association: 'CONTRIBUTOR',
submitted_at: Time.parse('2024-08-07 14:30:20 UTC')
}
]
)
stub_github(
'https://api.github.com/repos/foo/foo/pulls/90/reviews?per_page=100',
body: [
{
id: 22_449_210, body: 'Some text 1',
user: { login: 'yegor257', id: 526_302, type: 'User' },
state: 'CHANGES_REQUESTED', author_association: 'CONTRIBUTOR',
submitted_at: Time.parse('2024-08-02 16:00:20 UTC')
},
{
id: 22_449_215, body: 'Some text 2',
user: { login: 'yegor257', id: 526_302, type: 'User' },
state: 'CHANGES_REQUESTED', author_association: 'CONTRIBUTOR',
submitted_at: Time.parse('2024-08-05 15:30:00 UTC')
},
{
id: 22_449_220, body: 'Some text 3',
user: { login: 'yegor257', id: 526_302, type: 'User' },
state: 'CHANGES_REQUESTED', author_association: 'CONTRIBUTOR',
submitted_at: Time.parse('2024-08-06 13:25:00 UTC')
},
{
id: 22_449_225, body: 'Some text 4',
user: { login: 'yegor257', id: 526_302, type: 'User' },
state: 'CHANGES_REQUESTED', author_association: 'CONTRIBUTOR',
submitted_at: Time.parse('2024-08-07 12:30:00 UTC')
}
]
)
stub_github(
'https://api.github.com/repos/foo/foo/pulls/85/reviews?per_page=100',
body: [
{
id: 22_449_100, body: 'Some text 1',
user: { login: 'yegor257', id: 526_302, type: 'User' },
state: 'CHANGES_REQUESTED', author_association: 'CONTRIBUTOR',
submitted_at: Time.parse('2024-08-01 10:00:00 UTC')
},
{
id: 22_449_110, body: 'Some text 2',
user: { login: 'yegor257', id: 526_302, type: 'User' },
state: 'CHANGES_REQUESTED', author_association: 'CONTRIBUTOR',
submitted_at: Time.parse('2024-08-02 11:00:00 UTC')
},
{
id: 22_449_115, body: 'Some text 3',
user: { login: 'yegor257', id: 526_302, type: 'User' },
state: 'CHANGES_REQUESTED', author_association: 'CONTRIBUTOR',
submitted_at: Time.parse('2024-08-02 20:00:00 UTC')
}
]
)
fb = Factbase.new
f = fb.insert
f.what = 'pmp'
f.area = 'scope'
f.qod_days = 7
f.qod_interval = 3
Time.stub(:now, Time.parse('2024-08-09 21:00:00 UTC')) do
load_it('quantity-of-deliverables', fb)
f = fb.query('(eq what "quantity-of-deliverables")').each.to_a.first
assert_equal(Time.parse('2024-08-03 00:00:00 +03:00'), f.since)
assert_equal(Time.parse('2024-08-09 21:00:00 UTC'), f.when)
assert_equal(5, f.total_reviews_submitted)
end
end
end