Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(chat-view): optimize message rendering by pre-computing ownership checks #2761

Merged
merged 1 commit into from
Mar 10, 2025
Merged

refactor(chat-view): optimize message rendering by pre-computing ownership checks #2761

merged 1 commit into from
Mar 10, 2025

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Mar 10, 2025

What does this do?

  • Pre-computing message ownership checks in the renderMessageGroup method to avoid redundant calculations during render.

Why are we making this change?

  • To improve rendering performance by reducing redundant function calls when displaying messages, especially in conversations with many messages.

How do I test this?

  • run tests as usual

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team March 10, 2025 11:20
@domw30 domw30 merged commit 5032af6 into main Mar 10, 2025
5 checks passed
@domw30 domw30 deleted the refactor/optimize-message-rendering-by-pre-computing-ownership-checks branch March 10, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30