Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(messenger-main): remove outdated rendering, processing and social channel handling of MessengerFeed from main messenger container #2757

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Mar 7, 2025

What does this do?

  • We're removing the MessengerFeed component import and social channel conditional rendering from the Main container.

Why are we making this change?

  • The Main container was still importing MessengerFeed and checking for social channels despite this functionality being moved to a separate app. This outdated code adds unnecessary complexity, performs redundant state derivation via denormalize, and potentially impacts performance by running unnecessary checks on each render.

How do I test this?

  • run tests as usual

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

domw30 added 4 commits March 7, 2025 13:02
…nally rendering MembersSidekick to improve performance
… rendering MembersSidekick to improve performance
…conditionally-rendering-MembersSidekick-to-improve-performance
…ocial channel handling of MessengerFeed from main messenger container
@domw30 domw30 requested a review from a team March 7, 2025 13:43
Base automatically changed from refactor/reduce-unnecessary-DOM-elements-by-conditionally-rendering-MembersSidekick-to-improve-performance to main March 7, 2025 13:43
@domw30 domw30 merged commit b398db6 into main Mar 7, 2025
5 checks passed
@domw30 domw30 deleted the refactor/remove-MessengerFeed-and-social-channel-handling-from-Main-container branch March 7, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant