refactor(feed-chat): reduce unnecessary DOM elements by conditionally rendering MembersSidekick to improve performance #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nally rendering MembersSidekick to improve performance
… rendering MembersSidekick to improve performance
Base automatically changed from
refactor/conditionally-render-MembersSidekick-to-improve-performance
to
main
March 7, 2025 13:25
…conditionally-rendering-MembersSidekick-to-improve-performance
domw30
deleted the
refactor/reduce-unnecessary-DOM-elements-by-conditionally-rendering-MembersSidekick-to-improve-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
We are modifying the rendering logic of the MembersSidekick component to ensure it is only rendered when the isSecondarySidekickOpen flag is true.
Why are we making this change?
This change is being made to improve the application's performance by reducing unnecessary DOM elements and memory usage when the MembersSidekick is not visible.
How do I test this?
Key decisions and Risk Assessment:
Things to consider: