Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(chat-saga): create detached task for marking conversations as read when performing validation #2746

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Mar 6, 2025

What does this do?

  • spawns marking conversations as read when validating conversations

Why are we making this change?

  • improve performance of app by running read receipts in background

How do I test this?

  • run tests as usual

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 merged commit 1eda40f into main Mar 6, 2025
5 checks passed
@domw30 domw30 deleted the refactor/mark-conversations-as-read-in-background branch March 6, 2025 12:02
colbr pushed a commit that referenced this pull request Mar 6, 2025
…s read when performing validation (#2746)

* refactor(chat-saga): create detached task for marking conversations as read when performing validation

* refactor: fix/update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant