Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(matrix-client): optimize room tags fetching by using in-memory data instead of network requests #2740

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Mar 4, 2025

What does this do?

  • We're eliminating network requests for room tags by accessing the data directly from Room objects already in memory.

Why are we making this change?

  • To significantly improve initial load performance by removing unnecessary network requests and making room tags immediately available during conversation loading.

How do I test this?

  • run tests as usual.
  • run the UI, monitor initial load of the app

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 merged commit 53660d9 into main Mar 4, 2025
5 checks passed
@domw30 domw30 deleted the refactor/optimize-room-tags-fetching-by-using-in-memory-data-instead-of-network-requests branch March 4, 2025 09:10
@domw30 domw30 requested a review from a team March 4, 2025 09:10
colbr pushed a commit that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant