Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat-saga/redux-state): handle race condition in conversation validation by checking URL path before setting active conversation #2736

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix(chat-saga/redux-state): handle race condition in conversation validation by checking URL path before setting active conversation #2736

merged 1 commit into from
Mar 3, 2025

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Mar 3, 2025

What does this do?

  • Adding a path consistency check in the conversation validation process to ensure the active conversation ID is only updated if the user hasn't navigated away.

Why are we making this change?

  • To fix a bug where rapidly navigating between conversations could cause UI inconsistencies between the URL and displayed conversation content.

How do I test this?

  • run tests as usual
  • run ui and navigate between channel and messenger apps

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30
fix(chat-saga/redux-state): handle race condition in conversation val…
ce0c575 
…idation by checking URL path before setting active conversation
@domw30 domw30 requested a review from a team March 3, 2025 12:23
@domw30 domw30 merged commit b2ca291 into main Mar 3, 2025
5 checks passed
@domw30 domw30 deleted the fix/race-condition-in-conversation-validation-by-checking-URL-path-before-setting-active-conversation branch March 3, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30