Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat-saga/chat-state): handle race condition in conversation validation by cancelling previous tasks #2734

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Mar 3, 2025

What does this do?

  • Implements a task cancellation mechanism in the conversation validation process to prevent race conditions when users navigate between conversations quickly.

Why are we making this change?

  • To fix a bug where the active conversation ID could be incorrectly set when a user navigates away from a conversation before validation completes, causing UI inconsistencies between the URL and displayed conversation.

How do I test this?

  • run tests as usual
  • run UI and navigate between channels and messenger app to test correct room content is rendered

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team March 3, 2025 11:09
@domw30 domw30 merged commit 7730da0 into main Mar 3, 2025
5 checks passed
@domw30 domw30 deleted the fix/race-condition-in-conversation-validation-by-cancelling-previous-tasks branch March 3, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant