Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(notifications-app): remove muted tab from notifications app #2723

Merged
merged 2 commits into from
Feb 28, 2025
Merged

refactor(notifications-app): remove muted tab from notifications app #2723

merged 2 commits into from
Feb 28, 2025

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Feb 28, 2025

What does this do?

  • removes muted tab from notifications app

Why are we making this change?

  • muted rooms no longer have tracking for unread notifications so the muted tab is no longer required

How do I test this?

  • run tests as usual

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team February 28, 2025 10:24
@domw30 domw30 merged commit 42ca95c into main Feb 28, 2025
5 checks passed
@domw30 domw30 deleted the refactor/remove-muted-tab-notifications branch February 28, 2025 10:50
@domw30 domw30 mentioned this pull request Mar 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30