Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect to last active conversation when social channel opened in messenger #2689

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Feb 21, 2025

What does this do?

  • Added path checking in performValidateActiveConversation saga to detect if we're in messenger app, and if so, redirect to last active conversation when attempting to open a social channel.

Why are we making this change?

  • To prevent social channels from being opened in messenger app since they should only be viewed in the feed app, while maintaining a smooth user experience by showing their last active messenger conversation instead.

How do I test this?

  • run tests as usual
  • run ui and test

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team February 21, 2025 13:21
@domw30 domw30 merged commit 63b4a2b into main Feb 21, 2025
5 checks passed
@domw30 domw30 deleted the fix/redirect-to-last-active-conversation-when-social-channel-opened-in-messenger branch February 21, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant