Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page-load-saga): ensure restricted route persists and does not switch to login route on load complete #2026

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Jun 19, 2024

Note :: Further refactoring required. We should move the android download functionality to the restricted component for the restricted route now that we would prevent the user from reaching the login route.

What does this do?

  • set load to complete if restricted route is reached due to device being mobile.
  • this removes test with regards to showing android download links.

Why are we making this change?

  • prevents the route changing to login when page load is complete on a mobile device.

How do I test this?

  • run tests as usual.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 merged commit de79742 into main Jun 19, 2024
5 checks passed
@domw30 domw30 deleted the fix/restricted-page-load-handling branch June 19, 2024 11:34
@domw30 domw30 requested a review from a team June 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant