Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(background): flickering page on data fetch #2023

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix(background): flickering page on data fetch #2023

merged 1 commit into from
Jun 19, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Jun 19, 2024

What does this do?

  • fixes the issue shown below.

Why are we making this change?

  • improve UI/UX

How do I test this?

  • run tests as usual.
  • run UI and render page.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

BEFORE:

flicker.mov

AFTER:

flicker2.mov

@domw30 domw30 requested a review from a team June 19, 2024 09:50
@domw30 domw30 merged commit 9340e53 into main Jun 19, 2024
5 checks passed
@domw30 domw30 deleted the fix/rendering-page-flicker branch June 19, 2024 09:52
domw30 added a commit that referenced this pull request Jun 19, 2024
@domw30
Revert "fix(background): flickering page on data fetch (#2023)"
1f1daf3 
This reverts commit 9340e53.
@domw30 domw30 mentioned this pull request Jun 19, 2024
Merged
domw30 added a commit that referenced this pull request Jun 19, 2024
@domw30
Revert "fix(background): flickering page on data fetch (#2023)" (#2024)
b0ff0fb 
This reverts commit 9340e53.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30